Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation comments to various binding-related classes #1541

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

exyi
Copy link
Member

@exyi exyi commented Jan 4, 2023

Part is taken from #1392 which won't be merged for a while.

@acizmarik acizmarik added this to the Version 4.1 milestone Feb 1, 2023
Copy link
Member

@acizmarik acizmarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/Framework/Framework/Binding/Expressions/IBinding.cs Outdated Show resolved Hide resolved
@@ -8,6 +8,7 @@

namespace DotVVM.Framework.Binding
{
[Obsolete("Use ControlPropertyBindingDataContextChangeAttribute instead.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how commonly this is used but we could mention it in release notes

src/Framework/Core/ViewModel/Direction.cs Outdated Show resolved Hide resolved
src/Framework/Core/ViewModel/Direction.cs Outdated Show resolved Hide resolved
exyi and others added 2 commits February 1, 2023 18:37
@exyi exyi merged commit 3dad60c into main Feb 1, 2023
@exyi exyi deleted the binding-inline-docs branch February 1, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants